beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lukecwik <...@git.apache.org>
Subject [GitHub] beam pull request #2910: [BEAM-2174] Update CoderRegistry to allow creating ...
Date Fri, 05 May 2017 03:35:38 GMT
GitHub user lukecwik opened a pull request:

    https://github.com/apache/beam/pull/2910

    [BEAM-2174] Update CoderRegistry to allow creating coders through CoderFactory for a wider
range of types

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`.
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    This removes getInstanceComponents and hard codes the inference for commonly "known" types
into Create removing the additionally complexity that was brought along with it.
    
    Also:
    * @DefaultCoder to become a CoderFactory
    * Created a ProtoCoderFactory which delegates to the ProtoCoder for all Message types
    * Created a SerializableCoderFactory which delegates to the SerializableCoder for all
Serializable types
    * Created a WritableCoderFactory which delegates to the Hadoop WritableCoder for all Hadoop
Writable types
    * Renamed getDefaultCoder to getCoder on CoderRegistry

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukecwik/incubator-beam coder_registrar

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2910.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2910
    
----
commit 917cc45411c602143450e109390b6a7750fc2f06
Author: Luke Cwik <lcwik@google.com>
Date:   2017-05-05T02:55:47Z

    [BEAM-2174] Update CoderRegistry to allow creating coders through CoderFactory for a wider
range of types

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message