beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markflyhigh <...@git.apache.org>
Subject [GitHub] beam pull request #2899: Fix HBaseIOTest: Move expected assertion to correct...
Date Thu, 04 May 2017 19:55:48 GMT
GitHub user markflyhigh opened a pull request:

    https://github.com/apache/beam/pull/2899

    Fix HBaseIOTest: Move expected assertion to correct place

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    HBaseIOTest#testWritingFailsTableDoesNotExist failed in OpenJDK8 ([here](https://builds.apache.org/job/beam_PostCommit_Java_JDK_Versions_Test/jdk=OpenJDK%208%20(on%20Ubuntu%20only),label=beam/8/console)).
Should move expect assertion to p.run() closer.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markflyhigh/incubator-beam fix-HBaseIOTest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2899.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2899
    
----
commit 92ed28d5bb7cd740879e85393c6137839eb7fad8
Author: Mark Liu <markliu@google.com>
Date:   2017-05-04T19:48:55Z

    Move thrown.expect to correct place

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message