beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] beam pull request #2864: [BEAM-1199] Remove POutput#recordAsOutput
Date Wed, 03 May 2017 18:00:52 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2864

    [BEAM-1199] Remove POutput#recordAsOutput

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    Add PValue#setDefaultName, for composite POutputs to use when they are
    being finalized.
    
    Expand POutput#finishSpecifyingOutput to take the name of the transform
    that is being finished.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam condense_finish_output

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2864.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2864
    
----
commit cc04e3356f9232049a00babccd76e9b9f1630f67
Author: Thomas Groh <tgroh@google.com>
Date:   2017-05-03T00:53:57Z

    Remove POutput#recordAsOutput
    
    Add PValue#setDefaultName, for composite POutputs to use when they are
    being finalized.
    
    Expand POutput#finishSpecifyingOutput to take the name of the transform
    that is being finished.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message