beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] beam pull request #2841: [BEAM-1340,BEAM-1345] Move state, timers, windowing...
Date Tue, 02 May 2017 20:03:12 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/2841

    [BEAM-1340,BEAM-1345] Move state, timers, windowing strategy into public folders

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    I have also revised these to mark more bits experimental and internal, but additional
suggestions welcome.
    
    Even though most of `util` should be package private or private somewhere else, I am focused
on the pieces that should be _public_ somewhere else.
    
    The way that I help to know what to move is to imagine that `util` did not exist, and
specifically that we did not publish its javadoc. Then what does a user need to know about?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam move-all-the-things

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2841.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2841
    
----
commit 40c489a300c23e038f9bdbea15135db361205ea0
Author: Kenneth Knowles <klk@google.com>
Date:   2017-05-02T17:29:33Z

    Move Java sdk.util.state to sdk.state

commit e3a3c7642c8a28f43f92a64ae044b56ab9254675
Author: Kenneth Knowles <klk@google.com>
Date:   2017-05-02T17:41:01Z

    Add @Internal and @Experimental to state package

commit 0b2d26c8a146779f3dce914f6d7ab9191d6182bf
Author: Kenneth Knowles <klk@google.com>
Date:   2017-05-02T19:31:02Z

    Mark TimeDomain experimental alongside Timers; improve javadoc

commit 1adbf521d8ffb9238dedf68826453502ca9ef7e7
Author: Kenneth Knowles <klk@google.com>
Date:   2017-05-02T19:46:46Z

    Move user-facing timer-related classes out of util

commit a5e8e145ed5d5d074a1bcfc3061821c5e53a60d6
Author: Kenneth Knowles <klk@google.com>
Date:   2017-05-02T19:53:26Z

    Move WindowingStrategy from util to values
    
    WindowingStrategy is a property on PCollection that transform authors
    regularly mess with. It is part of the public API.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message