beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] beam pull request #2811: [BEAM-2051] Cast to SimplePCollectionView instead o...
Date Mon, 01 May 2017 23:36:41 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2811

    [BEAM-2051] Cast to SimplePCollectionView instead of View.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    Wherever a View method is used, a concrete instance of
    SimplePCollectionView is required.
    
    PCollectionView is a marker interface. Runners can expect to
    always recieve a subclass of SimplePCollectionView, and cast to it when
    methods are required.
    
    Once this is live in the DataflowRunner, #2680 can be merged. This is #2680, without the
changes to PCollectionView

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam view_as_marker_prereq

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2811.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2811
    
----
commit c60d4a3ec4f07110a0a5d4c307bbbf9e5f4db416
Author: Thomas Groh <tgroh@google.com>
Date:   2017-04-21T16:46:28Z

    Cast to SimplePCollectionView instead of View.
    
    Wherever a View method is used, a concrete instance of
    SimplePCollectionView is required.
    
    PCollectionView is a marker interface. Runners can expect to
    always recieve a subclass of SimplePCollectionView, and cast to it when
    methods are required.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message