beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nigel Kilmer (JIRA)" <j...@apache.org>
Subject [jira] [Created] (BEAM-2392) Avoid use of proto builder clone
Date Wed, 31 May 2017 00:08:04 GMT
Nigel Kilmer created BEAM-2392:
----------------------------------

             Summary: Avoid use of proto builder clone
                 Key: BEAM-2392
                 URL: https://issues.apache.org/jira/browse/BEAM-2392
             Project: Beam
          Issue Type: Improvement
          Components: sdk-java-gcp
    Affects Versions: 2.1.0
            Reporter: Nigel Kilmer
            Assignee: Daniel Halperin
            Priority: Minor


BigtableServiceImpl uses the clone method of the MutateRowResponse proto builder here:

https://github.com/apache/beam/blob/04e3261818aed0c129e7c715e371463bf5b5c1b8/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImpl.java#L212

This method is not generated by the Google-internal Java proto generator, so I had to change
this to get it to work with an internal project. Are you interested in adding this change
to the main repository for compatibility, or would you prefer to keep the cleaner version
that uses clone?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message