beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2343) ExecutionContext and StepContext have a lot of unused cruft that obscures their use
Date Tue, 23 May 2017 00:38:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020480#comment-16020480
] 

ASF GitHub Bot commented on BEAM-2343:
--------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/3203

    [BEAM-2343] Eliminate ExecutionContext and strip down StepContext to what we actually
need

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    This just deletes a bunch of legacy stuff that _looks_ like shared runner support code
or APIs but is in fact totally unused or unimplemented.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam ExecutionContext

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3203.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3203
    
----
commit 80321507ffed963b3d37bf91551680b30b1009bd
Author: Kenneth Knowles <klk@google.com>
Date:   2017-05-22T22:28:44Z

    Move StepContext to top level

commit e357de5fbe548448ca12bc52c6e2530e769620c3
Author: Kenneth Knowles <klk@google.com>
Date:   2017-05-22T22:30:33Z

    Remove StepContext.noteOutput

commit b2e1a99dff6cd619d53f70f4ee08f173fd7a6777
Author: Kenneth Knowles <klk@google.com>
Date:   2017-05-22T22:34:37Z

    Rename BaseExecutionContext.StepContext to BaseStepContext

commit 5d91a0d7b6c4831b70276cb5ef67d165b7fd1d05
Author: Kenneth Knowles <klk@google.com>
Date:   2017-05-22T22:35:46Z

    Move BaseStepContext to the top level

commit 4809fa9bc5c41263836a50e4d281964730ec87c0
Author: Kenneth Knowles <klk@google.com>
Date:   2017-05-22T22:36:41Z

    Remove extraneous ExecutionContext parameter to BaseStepContext

commit 12f3150395e1c7280d2db43514a09c2a5febfb7b
Author: Kenneth Knowles <klk@google.com>
Date:   2017-05-22T22:44:17Z

    Implement StepContext directly in the DirectRunner

commit 1b3cb362b4150d227f5f691c779609d5b9bdfbb6
Author: Kenneth Knowles <klk@google.com>
Date:   2017-05-22T23:26:00Z

    Remove writePCollectionViewData from the Beam codebase

commit e9b5a1c102fcee834c8a3492e15e2e4aa5ae978e
Author: Kenneth Knowles <klk@google.com>
Date:   2017-05-22T23:50:41Z

    Inline and delete BaseExecutionContext

commit afe57091f72d9b9ad455996454ef04bd5372fde2
Author: Kenneth Knowles <klk@google.com>
Date:   2017-05-23T00:33:38Z

    Delete unused ExecutionContext

----


> ExecutionContext and StepContext have a lot of unused cruft that obscures their use
> -----------------------------------------------------------------------------------
>
>                 Key: BEAM-2343
>                 URL: https://issues.apache.org/jira/browse/BEAM-2343
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>
> Like {{noteOutput}} and pretty much the existence of {{ExecutionContext}} at all.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message