beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2316) GcsUtil matches GCS glob * as though it is **
Date Thu, 18 May 2017 15:35:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015954#comment-16015954
] 

ASF GitHub Bot commented on BEAM-2316:
--------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/3173

    [BEAM-2316] Restore non-recursive globs in GcsUtil

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    R: @meunierd this is what I have in mind as a quick fix, basically. I stopped short of
actually parsing the glob and translating it...

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam GcsUtil

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3173.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3173
    
----
commit 578ccfd53286a654fad6bb412cca901907394cd8
Author: Kenneth Knowles <klk@google.com>
Date:   2017-05-18T15:32:29Z

    Restore non-recursive globs in GcsUtil

----


> GcsUtil matches GCS glob * as though it is **
> ---------------------------------------------
>
>                 Key: BEAM-2316
>                 URL: https://issues.apache.org/jira/browse/BEAM-2316
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-gcp
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>
> A pattern like {{"prefix/*"}} previously did not match files in subdirectories, but was
restricted by the {{/}} character. Now it matches things like {{"prefix/subdir/foo.txt"}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message