beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2244) Move runner-facing Metrics classes to runners core
Date Wed, 10 May 2017 22:57:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005601#comment-16005601
] 

ASF GitHub Bot commented on BEAM-2244:
--------------------------------------

GitHub user dhalperi opened a pull request:

    https://github.com/apache/beam/pull/3064

    [BEAM-2244] Cherry-pick #3053 to release-2.0.0

    [BEAM-2244] Move details of Metrics to Runners Core
    
    Largeish changes this required were:
    
      - splitting the MetricsContainer into an interface in Java Core with
        an implementation in Runners Core
      - modifying the various *Cell classes to have a name
      - cleaning up dependency cross-fire.
    
    R: @bjchambers confirm this is a valid CP. Also, note there was one merge conflict fixup
in SourceRdd -- check that one out.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/beam cp-3053

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3064.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3064
    
----
commit e2f331e517804cc3ed0262fe8cc0772a4629d310
Author: bchambers <bchambers@google.com>
Date:   2017-05-09T22:45:50Z

    [BEAM-2244] Move details of Metrics to Runners Core
    
    Largeish changes this required were:
    
      - splitting the MetricsContainer into an interface in Java Core with
        an implementation in Runners Core
      - modifying the various *Cell classes to have a name
      - cleaning up dependency cross-fire.

----


> Move runner-facing Metrics classes to runners core
> --------------------------------------------------
>
>                 Key: BEAM-2244
>                 URL: https://issues.apache.org/jira/browse/BEAM-2244
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Ben Chambers
>            Assignee: Ben Chambers
>             Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message