beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2241) Correctly mark top level classes and functions as private
Date Mon, 15 May 2017 16:43:05 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010822#comment-16010822
] 

ASF GitHub Bot commented on BEAM-2241:
--------------------------------------

Github user mariapython closed the pull request at:

    https://github.com/apache/beam/pull/3040


> Correctly mark top level classes and functions as private
> ---------------------------------------------------------
>
>                 Key: BEAM-2241
>                 URL: https://issues.apache.org/jira/browse/BEAM-2241
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py
>            Reporter: Chamikara Jayalath
>            Assignee: Chamikara Jayalath
>             Fix For: 2.0.0
>
>
> Seems like some of the top level classes and function of Python SDK are unnecessarily
public (does not start with _ ). We should update Python SDK so that top level classes and
functions that are only used within the corresponding modules are private. Additionally, any
top level classes and functions that are not expected to be used by end-users (pipeline/source/ptransform
authors) should be clearly documented.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message