beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2190) User depending on IO-GCP still gets a dependency on protobuf-lite
Date Mon, 08 May 2017 18:38:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001301#comment-16001301
] 

ASF GitHub Bot commented on BEAM-2190:
--------------------------------------

GitHub user dhalperi opened a pull request:

    https://github.com/apache/beam/pull/2957

    [BEAM-2190] Cherry-pick #2934 into release-2.0.0

    This cherry-picks #2934 
    
    R: @davorbonaci 
    
    ---
    
    Even if Beam appears to have the correct dependencies, we cannot
    guarantee that modules that depend on us transitively get the right
    dependencies. For example, even though grpc-protobuf-lite has
    protobuf-lite excluded, and the Maven Enforcer banned-dependencies
    check passes... if a user happens to get a transitive dependency on
    grpc-all first, they may pull in grpc-protobuf from that other source
    without the exclusion. Thus we need to exclude protobuf-lite from
    grpc-all as well.
    
    While we're here, also add guava-jdk5 to the set of banned dependencies,
    though (as above) we cannot currently properly identify the places it
    might be transitively exposed in a users' pom.xml.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/beam cp-2934

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2957.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2957
    
----

----


> User depending on IO-GCP still gets a dependency on protobuf-lite
> -----------------------------------------------------------------
>
>                 Key: BEAM-2190
>                 URL: https://issues.apache.org/jira/browse/BEAM-2190
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-gcp
>            Reporter: Daniel Halperin
>            Assignee: Daniel Halperin
>             Fix For: 2.0.0
>
>
> Somehow a user with a single dependency on {{org.apache.beam:beam-sdks-java-io-google-cloud-platform}}
gets a transitive dependency on {{protobuf-lite}}, despite it being banned in our build and
excluded from {{grpc-protobuf-lite}}.
> We must need to do more work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message