beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2166) Remove Coder.Context from the public API
Date Sat, 06 May 2017 01:08:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999207#comment-15999207
] 

ASF GitHub Bot commented on BEAM-2166:
--------------------------------------

GitHub user robertwb opened a pull request:

    https://github.com/apache/beam/pull/2933

    [BEAM-2166]  Use contextless encode/decode by default.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertwb/incubator-beam context-encode-decode

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2933.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2933
    
----
commit ecefdd9518e0ba4a29a627aed661e45a494a1810
Author: Robert Bradshaw <robertwb@gmail.com>
Date:   2017-05-05T23:20:37Z

    Remove explicit used of nested contexts.
    
        find . -type f -name '*.java' | xargs sed -i '' 's/\([.]..code[(].*\),  *context.nested..[)]/\1)/'
        find . -type f -name '*.java' | xargs sed -i '' 's/\([.]..code[(].*\),  *nestedContext[)]/\1)/'
        find . -type f -name '*.java' | xargs sed -i '' 's/\([.]..code[(].*\),  *Context.NESTED[)]/\1)/'
        find . -type f -name '*.java' | xargs sed -i '' 's/\([.]..code[(].*\),  *[^ ]*.Context.NESTED[)]/\1)/'
    
    Added back explicit context in CoGbkResult.java due to compile error.

commit f2bd184a86a743823bb7d9412c279399ec7ec259
Author: Robert Bradshaw <robertwb@gmail.com>
Date:   2017-05-05T23:36:47Z

    Remove contexts from coders where they'll never be used.

commit dad18a0414d4eda561437d896b3dad075e7f0ac9
Author: Robert Bradshaw <robertwb@gmail.com>
Date:   2017-05-06T00:24:02Z

    automated context removal or redirection

commit f6a414e56ef47a8894243374b0909078eba9147e
Author: Robert Bradshaw <robertwb@gmail.com>
Date:   2017-05-06T00:27:13Z

    get it compiling

commit 77059753f8332ff49aa2f60f2992a7b276e56f46
Author: Robert Bradshaw <robertwb@gmail.com>
Date:   2017-05-06T00:35:35Z

    Remove en/decodeOuter and default encode/decode methods.
    
    Now only the context-free encode() and decode() methods are abstract.

----


> Remove Coder.Context from the public API
> ----------------------------------------
>
>                 Key: BEAM-2166
>                 URL: https://issues.apache.org/jira/browse/BEAM-2166
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core, sdk-py
>    Affects Versions: First stable release
>            Reporter: Robert Bradshaw
>            Assignee: Robert Bradshaw
>             Fix For: First stable release
>
>
> Justification: 
> * Contexts add confusion and complexity to the public API (e.g. https://issues.apache.org/jira/browse/BEAM-1448)
> * Leaf (user-written) coders are nearly always nested.
> * Coders are being removed from sources, which was the initial need for context.
> * It is unclear how much value, if any, this provides for internal performance.
> * There may be performance (as well as simplification) gains in removing this for the
Fn API.
> Fully removing this distinction from the internals can be defered  until the last bullet
points are more completely investigated. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message