beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2153) Move connection management in JmsIO to setup/teardown methods
Date Fri, 12 May 2017 13:05:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008093#comment-16008093
] 

ASF GitHub Bot commented on BEAM-2153:
--------------------------------------

GitHub user hepeknet opened a pull request:

    https://github.com/apache/beam/pull/3116

    [BEAM-2153] Move connection management in JmsIO to setup/teardown methods

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-2153] Move connection management in JmsIO to setup/teardown methods`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    @jbonofre you should also check this since you wrote JmsIO
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hepeknet/beam BEAM-2153

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3116.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3116
    
----
commit 092bb22ee47f343b649a0627440f95e5a4bcbc33
Author: Borisa Zivkovic <borisa.zivkovic@huawei.com>
Date:   2017-05-12T13:03:02Z

    Move connection management in JmsIO to setup/teardown methods

----


> Move connection management in JmsIO to setup/teardown methods
> -------------------------------------------------------------
>
>                 Key: BEAM-2153
>                 URL: https://issues.apache.org/jira/browse/BEAM-2153
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-extensions
>            Reporter: Thomas Groh
>
> This will reduce the complexity of process element (no more try/catch -> teardown)
and improve performance (by reusing connections)
> If there's a reason that these must be in StartBundle/FinishBundle, these should be commented.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message