beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Borisa Zivkovic (JIRA)" <>
Subject [jira] [Commented] (BEAM-1982) Refactor PTransformOverrideFactories to remove code duplication
Date Mon, 08 May 2017 11:40:04 GMT


Borisa Zivkovic commented on BEAM-1982:

Do you want this to be done 1) only at the level of<InputT,
OutputT, TransformT> and its subclasses) or 2) we should introduce new abstract class implementing
org.apache.beam.sdk.runners.PTransformOverrideFactory<InputT, OutputT, TransformT> and
adding this common code?

Two is more intrusive.

> Refactor PTransformOverrideFactories to remove code duplication
> ---------------------------------------------------------------
>                 Key: BEAM-1982
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Thomas Groh
>            Priority: Minor
>              Labels: newbie, starter
> The majority of the factories take in a single PCollection as input and produce a single
PCollection as output; the code to extract the single input can be invisible as part of the
class hierarchy, rather than explicitly called in every override.

This message was sent by Atlassian JIRA

View raw message