beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1938) Side Inputs should be part of the expanded inputs
Date Fri, 19 May 2017 20:04:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017950#comment-16017950
] 

ASF GitHub Bot commented on BEAM-1938:
--------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/3188

    [BEAM-1938] Include Additional PTransform inputs in Transform Nodes

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    Add the value of PTransform.getAdditionalInputs in the inputs of a
    TransformHierarchy node.
    
    Fork the Node constructor to reduce nullability
    
    This slightly simplifies the constructor implementation(s).
    
    Update the DirectRunner to track main inputs instead of all inputs.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam additional_inputs_in_transform_nodes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3188.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3188
    
----
commit cd7cd87bd79291278e3c940e3e0013323b1821b9
Author: Thomas Groh <tgroh@google.com>
Date:   2017-04-05T00:43:48Z

    Include Additional PTransform inputs in Transform Nodes
    
    Add the value of PTransform.getAdditionalInputs in the inputs of a
    TransformHierarchy node.
    
    Fork the Node constructor to reduce nullability
    
    This slightly simplifies the constructor implementation(s).
    
    Update the DirectRunner to track main inputs instead of all inputs.

----


> Side Inputs should be part of the expanded inputs
> -------------------------------------------------
>
>                 Key: BEAM-1938
>                 URL: https://issues.apache.org/jira/browse/BEAM-1938
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>
> Required for the Java SDK to construct the runner API graphs without inspecting arbitrary
transforms.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message