beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1876) GroupIntoBatches may be able to use Combine.BinaryCombineLongFn
Date Wed, 03 May 2017 15:27:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995068#comment-15995068
] 

ASF GitHub Bot commented on BEAM-1876:
--------------------------------------

GitHub user hepeknet opened a pull request:

    https://github.com/apache/beam/pull/2859

    reusing combine in GroupIntoBatches

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-1876 #>] GroupIntoBatches may be able to use Combine.BinaryCombineLongFn`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    @tgroh  are you happy with this?
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hepeknet/beam BEAM-1876

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2859.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2859
    
----
commit ef7e0b19bf8e36b3526e49c30f2e744bdbb3c283
Author: Borisa Zivkovic <borisa.zivkovic@huawei.com>
Date:   2017-05-03T15:22:18Z

    reusing combine

----


> GroupIntoBatches may be able to use Combine.BinaryCombineLongFn
> ---------------------------------------------------------------
>
>                 Key: BEAM-1876
>                 URL: https://issues.apache.org/jira/browse/BEAM-1876
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Priority: Trivial
>              Labels: newbie, starter
>
> This should reduce the complexity of the CombineFn by removing the need to merge accumulators
or extract output.
> It may need to be refactored into a variable so the accumulator coder can be obtained.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message