beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1073) Staged websites have extra whitespace around links
Date Fri, 26 May 2017 16:48:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026490#comment-16026490
] 

ASF GitHub Bot commented on BEAM-1073:
--------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam-site/pull/254

    [BEAM-1073] Do not use BeautifulSoup prettify, which is known to corrupt HTML

    Opening this to see what happens to the staged HTML when we don't prettify.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam-site no-prettify

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam-site/pull/254.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #254
    
----
commit 61a36acad7cceab2b2787368c32bb6b903bf7eef
Author: Kenneth Knowles <klk@google.com>
Date:   2017-05-26T16:45:45Z

    Do not use BeautifulSoup prettify, which is known to corrupt HTML

----


> Staged websites have extra whitespace around links
> --------------------------------------------------
>
>                 Key: BEAM-1073
>                 URL: https://issues.apache.org/jira/browse/BEAM-1073
>             Project: Beam
>          Issue Type: Bug
>          Components: website
>    Affects Versions: Not applicable
>            Reporter: Daniel Halperin
>            Assignee: Jason Kuster
>            Priority: Minor
>             Fix For: Not applicable
>
>
> cc [~davor] [~frances]
> e.g., http://apache-beam-website-pull-requests.storage.googleapis.com/97/documentation/runners/flink/index.html
> has this source when staged:
> {code}
>         <li>
>          <a href="/97/documentation/programming-guide/index.html">
>           Programming Guide
>          </a>
>         </li>
> {code}
> but this source:
> {code}
> <li><a href="/documentation/programming-guide/">Programming Guide</a></li>
> {code}
> when live. I assume this comes from the rewriting tool we use to make directories work.
> The former (space between end of {{Guide}} and {{</a>}}) is what I assume causes
the visual effects.
> NBD, but I spent a while figuring out why someone's PR caused this to happen and then
saw it disappear after merging and going live.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message