beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Halperin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1073) Staged websites have extra whitespace around links
Date Fri, 26 May 2017 16:39:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026479#comment-16026479
] 

Daniel Halperin commented on BEAM-1073:
---------------------------------------

The code for this is in the {{beam-site}} repo under the jenkins folder: https://github.com/apache/beam-site/blob/asf-site/.jenkins/append_index_html_to_internal_links.py



> Staged websites have extra whitespace around links
> --------------------------------------------------
>
>                 Key: BEAM-1073
>                 URL: https://issues.apache.org/jira/browse/BEAM-1073
>             Project: Beam
>          Issue Type: Bug
>          Components: website
>    Affects Versions: Not applicable
>            Reporter: Daniel Halperin
>            Assignee: Jason Kuster
>            Priority: Minor
>             Fix For: Not applicable
>
>
> cc [~davor] [~frances]
> e.g., http://apache-beam-website-pull-requests.storage.googleapis.com/97/documentation/runners/flink/index.html
> has this source when staged:
> {code}
>         <li>
>          <a href="/97/documentation/programming-guide/index.html">
>           Programming Guide
>          </a>
>         </li>
> {code}
> but this source:
> {code}
> <li><a href="/documentation/programming-guide/">Programming Guide</a></li>
> {code}
> when live. I assume this comes from the rewriting tool we use to make directories work.
> The former (space between end of {{Guide}} and {{</a>}}) is what I assume causes
the visual effects.
> NBD, but I spent a while figuring out why someone's PR caused this to happen and then
saw it disappear after merging and going live.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message