beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-885) Move PipelineOptions from Pipeline.create() to Pipeline.run()
Date Wed, 03 May 2017 10:10:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994612#comment-15994612
] 

ASF GitHub Bot commented on BEAM-885:
-------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/2857

    [BEAM-885] Eliminate Pipeline.getOptions

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    This builds on a pending branch of @vikkyrk. (thanks! this was really easy now)
    
    R: @tgroh just the last commit here.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam getOptions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2857.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2857
    
----
commit 67fa9da0696c755888636ee64275fb213c88386a
Author: Vikas Kedigehalli <vikasrk@google.com>
Date:   2017-05-02T20:55:32Z

    Remove job name usages from BigQueryIO at pipeline construction time

commit d1f39883ead7c6ace2a112d52ccc4be645e2f2e1
Author: Vikas Kedigehalli <vikasrk@google.com>
Date:   2017-05-03T00:14:06Z

    Clean up

commit 075ceac76e7ef4998cc09c8751ced416bff8ed1d
Author: Vikas Kedigehalli <vikasrk@google.com>
Date:   2017-05-03T02:21:50Z

    Remote tempLocation usage during pipeline construction time in
    BigQueryIO

commit d49d8aa014b35220f74f289d5b7d1e794a44aeb7
Author: Kenneth Knowles <klk@google.com>
Date:   2017-05-03T10:06:36Z

    Eliminate Pipeline.getOptions

----


> Move PipelineOptions from Pipeline.create() to Pipeline.run()
> -------------------------------------------------------------
>
>                 Key: BEAM-885
>                 URL: https://issues.apache.org/jira/browse/BEAM-885
>             Project: Beam
>          Issue Type: New Feature
>          Components: beam-model-runner-api, sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Kenneth Knowles
>              Labels: backward-incompatible
>             Fix For: First stable release
>
>
> The specification of a Pipeline should be independent of its PipelineOptions. This delays
specification of the options, including choices like Pipeline Runner.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message