beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-659) WindowFn#isCompatible should provide a meaningful reason
Date Wed, 10 May 2017 17:27:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005073#comment-16005073
] 

ASF GitHub Bot commented on BEAM-659:
-------------------------------------

Github user kennknowles closed the pull request at:

    https://github.com/apache/beam/pull/3038


> WindowFn#isCompatible should provide a meaningful reason
> --------------------------------------------------------
>
>                 Key: BEAM-659
>                 URL: https://issues.apache.org/jira/browse/BEAM-659
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Huafeng Wang
>            Priority: Minor
>              Labels: easy, easyfix, starter
>             Fix For: 2.0.0
>
>
> {{WindowFn#isCompatible(...)}} returns a true/false answer without any explanation of
why; it suffers from a form of [boolean blindness|https://existentialtype.wordpress.com/2011/03/15/boolean-blindness/].
> We alleviated this for {{Coder#isDeterministic()}} by switching to {{Coder#verifyDeterministic()}}
which can raise an exception describing why it is not deterministic (it could just as easily
have been a return value).
> We should do the same for {{WindowFn#isCompatible(...)}}.
> See here: http://stackoverflow.com/questions/39617897/inputs-to-flatten-had-incompatible-window-windowfns-when-cogroupbykey-with-calen
> (a decent {{toString}} would go a long way, for immediate and trivial improvement)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message