beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-163) Warn the user when a PCollection (via Window.into) has smaller allowedLateness than upstream
Date Tue, 16 May 2017 13:18:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012351#comment-16012351
] 

ASF GitHub Bot commented on BEAM-163:
-------------------------------------

GitHub user hepeknet opened a pull request:

    https://github.com/apache/beam/pull/3163

    [BEAM-163] Warn the user when a PCollection (via Window.into) has smaller allowe…

    …dLateness than upstream
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-163] Warn the user when a PCollection (via Window.into) has smaller allowedLateness
than upstream`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    @kennknowles  you happy with this?
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hepeknet/beam BEAM-163

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3163.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3163
    
----
commit b1a9c43afaaa6cda4b281967e19751fb99bf91db
Author: Borisa Zivkovic <borisa.zivkovic@huawei.com>
Date:   2017-05-16T13:16:07Z

    Warn the user when a PCollection (via Window.into) has smaller allowedLateness than upstream

----


> Warn the user when a PCollection (via Window.into) has smaller allowedLateness than upstream
> --------------------------------------------------------------------------------------------
>
>                 Key: BEAM-163
>                 URL: https://issues.apache.org/jira/browse/BEAM-163
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Priority: Minor
>              Labels: windowing
>
> In this situation, data may be dropped downstream even though it was allowed upstream.
It is probably quite rare that this is desirable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message