beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tg...@apache.org
Subject [2/2] beam git commit: Remove verifyDeterministic from StructuredCoder
Date Wed, 10 May 2017 17:50:29 GMT
Remove verifyDeterministic from StructuredCoder

This is replaced within all uses in the Core SDK by
Coder.verifyDeterministic(Coder, String, List<Coder>), which is a
general utility.


Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/439fd202
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/439fd202
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/439fd202

Branch: refs/heads/master
Commit: 439fd202f59ce84ef3f1cf5bd6d076deb949e93d
Parents: ddea2d1
Author: Thomas Groh <tgroh@google.com>
Authored: Tue May 9 18:09:37 2017 -0700
Committer: Thomas Groh <tgroh@google.com>
Committed: Wed May 10 10:50:21 2017 -0700

----------------------------------------------------------------------
 .../apache/beam/sdk/coders/StructuredCoder.java    | 17 -----------------
 1 file changed, 17 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/beam/blob/439fd202/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/StructuredCoder.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/StructuredCoder.java
b/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/StructuredCoder.java
index a145215..2eb662b 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/StructuredCoder.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/StructuredCoder.java
@@ -18,7 +18,6 @@
 package org.apache.beam.sdk.coders;
 
 import java.io.ByteArrayOutputStream;
-import java.util.Arrays;
 import java.util.Collections;
 import java.util.List;
 import org.apache.beam.sdk.values.TypeDescriptor;
@@ -100,22 +99,6 @@ public abstract class StructuredCoder<T> extends Coder<T>
{
     return builder.toString();
   }
 
-  protected void verifyDeterministic(String message, Iterable<Coder<?>> coders)
-      throws NonDeterministicException {
-    for (Coder<?> coder : coders) {
-      try {
-        coder.verifyDeterministic();
-      } catch (NonDeterministicException e) {
-        throw new NonDeterministicException(this, message, e);
-      }
-    }
-  }
-
-  protected void verifyDeterministic(String message, Coder<?>... coders)
-      throws NonDeterministicException {
-    verifyDeterministic(message, Arrays.asList(coders));
-  }
-
   /**
    * {@inheritDoc}
    *


Mime
View raw message