beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dhalp...@apache.org
Subject [2/3] beam git commit: [BEAM-2212] FileBasedSource: improve message when logging.
Date Mon, 08 May 2017 21:15:58 GMT
[BEAM-2212] FileBasedSource: improve message when logging.

ValueProvider should not be printed, rather the string instead.


Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/e0faeeef
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/e0faeeef
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/e0faeeef

Branch: refs/heads/release-2.0.0
Commit: e0faeeef80211ddbc632e622ecefc1e005c5ca29
Parents: 265405b
Author: Dan Halperin <dhalperi@google.com>
Authored: Fri May 5 19:06:03 2017 -0700
Committer: Dan Halperin <dhalperi@google.com>
Committed: Mon May 8 14:15:43 2017 -0700

----------------------------------------------------------------------
 .../src/main/java/org/apache/beam/sdk/io/FileBasedSource.java    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/beam/blob/e0faeeef/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSource.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSource.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSource.java
index 2beb5e0..4e07342 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSource.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSource.java
@@ -268,7 +268,7 @@ public abstract class FileBasedSource<T> extends OffsetBasedSource<T>
{
       LOG.info(
           "Splitting filepattern {} into bundles of size {} took {} ms "
               + "and produced {} files and {} bundles",
-          fileOrPatternSpec,
+          fileOrPatternSpec.get(),
           desiredBundleSizeBytes,
           System.currentTimeMillis() - startTime,
           expandedFiles.size(),
@@ -327,7 +327,7 @@ public abstract class FileBasedSource<T> extends OffsetBasedSource<T>
{
       }
       LOG.debug(
           "Creating a reader for file pattern {} took {} ms",
-          fileOrPatternSpec,
+          fileOrPatternSpec.get(),
           System.currentTimeMillis() - startTime);
       if (fileReaders.size() == 1) {
         return fileReaders.get(0);


Mime
View raw message