beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From k...@apache.org
Subject [1/2] beam git commit: Adjust error message expectation in DoFnSignaturesTest
Date Fri, 05 May 2017 02:24:45 GMT
Repository: beam
Updated Branches:
  refs/heads/master b130d7aac -> 7903e59c4


Adjust error message expectation in DoFnSignaturesTest


Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/6be71c9a
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/6be71c9a
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/6be71c9a

Branch: refs/heads/master
Commit: 6be71c9a1c2ec43478e2ddaedaba67608de129ae
Parents: b130d7a
Author: Kenneth Knowles <klk@google.com>
Authored: Thu May 4 19:03:50 2017 -0700
Committer: Kenneth Knowles <klk@google.com>
Committed: Thu May 4 19:03:50 2017 -0700

----------------------------------------------------------------------
 .../apache/beam/sdk/transforms/reflect/DoFnSignaturesTest.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/beam/blob/6be71c9a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesTest.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesTest.java
index 5b97a55..cffb0ad 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesTest.java
@@ -385,7 +385,7 @@ public class DoFnSignaturesTest {
     thrown.expectMessage("my-id");
     thrown.expectMessage("myfield1");
     thrown.expectMessage("myfield2");
-    thrown.expectMessage(not(mentionsState()));
+    thrown.expectMessage(not(containsString("State"))); // lowercase "state" is in the package
name
     thrown.expectMessage(mentionsTimers());
     DoFnSignature sig =
         DoFnSignatures.getSignature(
@@ -407,7 +407,7 @@ public class DoFnSignaturesTest {
     thrown.expectMessage("Timer declarations must be final");
     thrown.expectMessage("Non-final field");
     thrown.expectMessage("myfield");
-    thrown.expectMessage(not(mentionsState()));
+    thrown.expectMessage(not(containsString("State"))); // lowercase "state" is in the package
name
     thrown.expectMessage(mentionsTimers());
     DoFnSignature sig =
         DoFnSignatures.getSignature(


Mime
View raw message