beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dhalp...@apache.org
Subject [2/9] beam git commit: ReadTranslator: remove outdated comment
Date Thu, 04 May 2017 16:32:52 GMT
ReadTranslator: remove outdated comment


Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/56b1280d
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/56b1280d
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/56b1280d

Branch: refs/heads/master
Commit: 56b1280d51b2458de93c7a5e2f31822fe6cf1718
Parents: d050477
Author: Dan Halperin <dhalperi@google.com>
Authored: Wed May 3 18:18:52 2017 -0700
Committer: Dan Halperin <dhalperi@google.com>
Committed: Thu May 4 09:32:45 2017 -0700

----------------------------------------------------------------------
 .../main/java/org/apache/beam/runners/dataflow/ReadTranslator.java | 2 --
 1 file changed, 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/beam/blob/56b1280d/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/ReadTranslator.java
----------------------------------------------------------------------
diff --git a/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/ReadTranslator.java
b/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/ReadTranslator.java
index c304c32..396c305 100755
--- a/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/ReadTranslator.java
+++ b/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/ReadTranslator.java
@@ -46,8 +46,6 @@ class ReadTranslator implements TransformTranslator<Read.Bounded<?>>
{
       PTransform<?, ? extends PValue> transform,
       TranslationContext context) {
     try {
-      // TODO: Move this validation out of translation once IOChannelUtils is portable
-      // and can be reconstructed on the worker.
       if (source instanceof FileBasedSource) {
         ValueProvider<String> filePatternOrSpec =
             ((FileBasedSource<?>) source).getFileOrPatternSpecProvider();


Mime
View raw message