Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
From: iemejia <git@git.apache.org>
To: commits@beam.apache.org
Reply-To: commits@beam.apache.org
Message-ID: <git-pr-2704-beam@git.apache.org>
Subject: [GitHub] beam pull request #2704: Remove unneeded elements from the POM files
Content-Type: text/plain
Date: Wed, 26 Apr 2017 14:33:57 +0000 (UTC)
archived-at: Wed, 26 Apr 2017 14:33:59 -0000

GitHub user iemejia opened a pull request:

    https://github.com/apache/beam/pull/2704

    Remove unneeded elements from the POM files

    The compiler-plugin, jar-plugin and checkstyle are all inherited from
    the parent pom. This was validated by using:
    
        mvn help:effective-pom.
    
    Also we don't need the extra configuration for surefire because the
    TestPipelineRunner uses DirectRunner if it is available instead of the
    DummyRunner.
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/iemejia/beam clean-pom-files

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2704.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2704
    
----
commit a5199a73100b9d321a5da22e56fa9773a0569454
Author: Ismaël Mejía <iemejia@apache.org>
Date:   2017-04-26T14:18:33Z

    Remove unneeded elements from the POM files
    
    The compiler-plugin, jar-plugin and checkstyle are all inherited from
    the parent pom. This was validated by using:
    
        mvn help:effective-pom.
    
    Also we don't need the extra configuration for surefire because the
    TestPipelineRunner uses DirectRunner if it is available instead of the
    DummyRunner.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---