Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
From: kennknowles <git@git.apache.org>
To: commits@beam.apache.org
Reply-To: commits@beam.apache.org
Message-ID: <git-pr-2627-beam@git.apache.org>
Subject: [GitHub] beam pull request #2627: [BEAM-1336] Separate StateSpec and KeyedStateSpec
Content-Type: text/plain
Date: Fri, 21 Apr 2017 04:16:14 +0000 (UTC)
archived-at: Fri, 21 Apr 2017 04:16:16 -0000

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/2627

    [BEAM-1336] Separate StateSpec and KeyedStateSpec

    Before this change, almost all uses of state had a type variable that
    existing only to support the esoteric use of a KeyedCombineFn in
    a state cell. Now those cases use a more verbose form of KeyedStateSpec.
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam StateSpec

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2627.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2627
    
----
commit c05bda1a5922e18ab29022403f7b9e00f4cea941
Author: Kenneth Knowles <klk@google.com>
Date:   2017-04-21T03:46:37Z

    Separate StateSpec and KeyedStateSpec
    
    Before this change, almost all uses of state had a type variable that
    existing only to support the esoteric use of a KeyedCombineFn in
    a state cell. Now those cases use a more verbose form of KeyedStateSpec.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---