Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E1603200C6C for ; Fri, 21 Apr 2017 00:12:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E033F160BB0; Thu, 20 Apr 2017 22:12:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 339FC160B9F for ; Fri, 21 Apr 2017 00:12:23 +0200 (CEST) Received: (qmail 80032 invoked by uid 500); 20 Apr 2017 22:12:22 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 79978 invoked by uid 99); 20 Apr 2017 22:12:21 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Apr 2017 22:12:21 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 22736F4A1F; Thu, 20 Apr 2017 22:12:21 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: jkff@apache.org To: commits@beam.apache.org Date: Thu, 20 Apr 2017 22:12:21 -0000 Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: [1/2] beam git commit: [BEAM-1992] Move Count.PerElement javadoc to a public place archived-at: Thu, 20 Apr 2017 22:12:24 -0000 Repository: beam Updated Branches: refs/heads/master e44918881 -> 8be1dacab [BEAM-1992] Move Count.PerElement javadoc to a public place Project: http://git-wip-us.apache.org/repos/asf/beam/repo Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/eb56f993 Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/eb56f993 Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/eb56f993 Branch: refs/heads/master Commit: eb56f9934726d51c07f1703caaa01cb80b27cc56 Parents: e449188 Author: wtanaka.com Authored: Mon Apr 17 21:57:10 2017 -1000 Committer: Eugene Kirpichov Committed: Thu Apr 20 15:12:01 2017 -0700 ---------------------------------------------------------------------- .../org/apache/beam/sdk/transforms/Count.java | 26 ++++++++++---------- 1 file changed, 13 insertions(+), 13 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/beam/blob/eb56f993/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Count.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Count.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Count.java index fd91430..abda1c6 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Count.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Count.java @@ -71,24 +71,17 @@ public class Count { } /** - * Returns a {@link PerElement Count.PerElement} {@link PTransform} that counts the number of - * occurrences of each element in its input {@link PCollection}. + * Returns a {@link PTransform} that counts the number of occurrences of each element + * in its input {@link PCollection}. * - *

See {@link PerElement Count.PerElement} for more details. - */ - public static PTransform, PCollection>> perElement() { - return new PerElement<>(); - } - - /** - * {@code Count.PerElement} takes a {@code PCollection} and returns a + *

The returned {@code PTransform} takes a {@code PCollection} and returns a * {@code PCollection>} representing a map from each distinct element of the input * {@code PCollection} to the number of times that element occurs in the input. Each key in the * output {@code PCollection} is unique. * - *

This transform compares two values of type {@code T} by first encoding each element using - * the input {@code PCollection}'s {@code Coder}, then comparing the encoded bytes. Because of - * this, the input coder must be deterministic. + *

The returned transform compares two values of type {@code T} by first encoding each + * element using the input {@code PCollection}'s {@code Coder}, then comparing the encoded + * bytes. Because of this, the input coder must be deterministic. * (See {@link org.apache.beam.sdk.coders.Coder#verifyDeterministic()} for more detail). * Performing the comparison in this manner admits efficient parallel evaluation. * @@ -101,6 +94,13 @@ public class Count { * PCollection> wordCounts = * words.apply(Count.perElement()); * } + */ + public static PTransform, PCollection>> perElement() { + return new PerElement<>(); + } + + /** + * Private implementation of {@link #perElement()}. * * @param the type of the elements of the input {@code PCollection}, and the type of the keys * of the output {@code PCollection}