Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
Date: Tue, 25 Apr 2017 00:28:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.apache.org
Message-ID: <JIRA.13065601.1492704698000.39788.1493080084130@Atlassian.JIRA>
In-Reply-To: <JIRA.13065601.1492704698000@Atlassian.JIRA>
References: <JIRA.13065601.1492704698000@Atlassian.JIRA> <JIRA.13065601.1492704698613@jira-lw-us.apache.org>
Subject: [jira] [Commented] (BEAM-2033) Implement ResourceIds for
 HadoopFileSystem
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 25 Apr 2017 00:28:13 -0000


    [ https://issues.apache.org/jira/browse/BEAM-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982169#comment-15982169 ] 

ASF GitHub Bot commented on BEAM-2033:
--------------------------------------

GitHub user ssisk opened a pull request:

    https://github.com/apache/beam/pull/2671

    [BEAM-2033] Add HadoopResourceId

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    merging person: I believe we'll want to do the implementation of this in a feature branch - this'd be a good time to create that feature branch. 
    
    R: @tgroh 
    
    It's worth noting that GcsResourceId spends a lot of time on worrying about slashes - that's not a thing we'll need for this since Hadoop's Path does a good job of cleaning it up, so all that's handled at a lower level.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ssisk/beam hfs-pre-req

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2671.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2671
    
----
commit 405cc1471c4fb0668c30fe6ffa232bd21c31c4ee
Author: Stephen Sisk <sisk@google.com>
Date:   2017-04-22T00:23:55Z

    Add HadoopResourceId

----


> Implement ResourceIds for HadoopFileSystem
> ------------------------------------------
>
>                 Key: BEAM-2033
>                 URL: https://issues.apache.org/jira/browse/BEAM-2033
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-java-extensions
>            Reporter: Stephen Sisk
>            Assignee: Stephen Sisk
>             Fix For: First stable release
>
>
> There's an empty class for HadoopResourceId already - we will implement it.
> This blocks most of the other implementation since we can't do much without ResourceIds


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)