Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7C460200C67 for ; Sun, 16 Apr 2017 17:52:48 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7AE8B160B87; Sun, 16 Apr 2017 15:52:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C17D1160B9A for ; Sun, 16 Apr 2017 17:52:47 +0200 (CEST) Received: (qmail 14015 invoked by uid 500); 16 Apr 2017 15:52:47 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 13889 invoked by uid 99); 16 Apr 2017 15:52:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 16 Apr 2017 15:52:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 885F4C0145 for ; Sun, 16 Apr 2017 15:52:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 984U-tf23bdc for ; Sun, 16 Apr 2017 15:52:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id F184A5F4EC for ; Sun, 16 Apr 2017 15:52:43 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EF0CCE06C5 for ; Sun, 16 Apr 2017 15:52:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4161E21B46 for ; Sun, 16 Apr 2017 15:52:42 +0000 (UTC) Date: Sun, 16 Apr 2017 15:52:42 +0000 (UTC) From: =?utf-8?Q?Isma=C3=ABl_Mej=C3=ADa_=28JIRA=29?= To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-1984) Enable dependency analysis of non-compile dependencies MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 16 Apr 2017 15:52:48 -0000 [ https://issues.apache.org/jira/browse/BEAM-1984?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D15970= 420#comment-15970420 ]=20 Isma=C3=ABl Mej=C3=ADa commented on BEAM-1984: ------------------------------------ One possible caveat is that a particular case can happen, a user can add a = dependency for tests but forget to put it in the test scope and get that co= de merged, then other user takes the new code with the dependency and runs = but skip the tests locally, in this case it will fail for them, this is not= bad because at least we will find the issue, but can be annoying for the p= erson who detects it. > Enable dependency analysis of non-compile dependencies > ------------------------------------------------------ > > Key: BEAM-1984 > URL: https://issues.apache.org/jira/browse/BEAM-1984 > Project: Beam > Issue Type: Improvement > Components: build-system > Affects Versions: Not applicable > Reporter: Isma=C3=ABl Mej=C3=ADa > Assignee: Isma=C3=ABl Mej=C3=ADa > Priority: Minor > > Currently the dependency analysis is ignoring test dependencies, however = if we run: > mvn install -Dmaven.test.skip=3Dtrue > It complains on multiple modules on dependencies that should be scoped pr= operly into the test mode but aren=E2=80=99t currently. -- This message was sent by Atlassian JIRA (v6.3.15#6346)