Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
Date: Thu, 13 Apr 2017 16:17:41 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: commits@beam.apache.org
Message-ID: <JIRA.13063837.1492100241000.277106.1492100261801@Atlassian.JIRA>
In-Reply-To: <JIRA.13063837.1492100241000@Atlassian.JIRA>
References: <JIRA.13063837.1492100241000@Atlassian.JIRA> <JIRA.13063837.1492100241317@jira-lw-us.apache.org>
Subject: [jira] [Created] (BEAM-1962) Connection should be closed in case
 start() throws exception
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 13 Apr 2017 16:17:45 -0000

Ted Yu created BEAM-1962:
----------------------------

             Summary: Connection should be closed in case start() throws exception
                 Key: BEAM-1962
                 URL: https://issues.apache.org/jira/browse/BEAM-1962
             Project: Beam
          Issue Type: Bug
          Components: sdk-java-extensions
            Reporter: Ted Yu
            Assignee: Davor Bonaci
            Priority: Minor


In JmsIO#start() :
{code}
      try {
        Connection connection;
        if (spec.getUsername() != null) {
          connection =
              connectionFactory.createConnection(spec.getUsername(), spec.getPassword());
        } else {
          connection = connectionFactory.createConnection();
        }
        connection.start();
        this.connection = connection;
      } catch (Exception e) {
        throw new IOException("Error connecting to JMS", e);
      }
{code}
If start() throws exception, connection should be closed.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)