Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
Date: Wed, 5 Apr 2017 08:01:41 +0000 (UTC)
From: "Stas Levin (JIRA)" <jira@apache.org>
To: commits@beam.apache.org
Message-ID: <JIRA.13058003.1490129820000.208400.1491379301991@Atlassian.JIRA>
In-Reply-To: <JIRA.13058003.1490129820000@Atlassian.JIRA>
References: <JIRA.13058003.1490129820000@Atlassian.JIRA> <JIRA.13058003.1490129820204@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (BEAM-1777) If PipelineEnforcement throws
 an exception after Pipeline.run() fails, it overwrites the original failure
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 05 Apr 2017 08:01:51 -0000


    [ https://issues.apache.org/jira/browse/BEAM-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956479#comment-15956479 ] 

Stas Levin edited comment on BEAM-1777 at 4/5/17 8:01 AM:
----------------------------------------------------------

[~tgroh] since I was unable to come up with a proper test for this, would you mind confirming it resolves the use-case you encountered (the fix is already in the master)?


was (Author: staslev):
[~tgroh] since I was unable to come up with a proper test for this, would you mind confirming it resolves the use-case you encountered?

> If PipelineEnforcement throws an exception after Pipeline.run() fails, it overwrites the original failure
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-1777
>                 URL: https://issues.apache.org/jira/browse/BEAM-1777
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Stas Levin
>
> The exception is thrown out of the finally block after the original exception was already thrown, and is not properly suppressed.
> If the Pipeline throws an exception in construction (including validation failures), this can cause {{AbandonedNodeEnforcement}} to attempt to traverse a {{Pipeline}} which is invalid, which throws another exception. That exception is improperly propagated instead of the original failure, which complicates debugging.
> An example is using an unkeyed input PCollection to a Stateful ParDo. The validation will fail, but the error message will suggest that a node has incompletely specified outputs (which is a consequence rather than a cause of having an invalid transform).


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)