Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 98AC2200C4D for ; Wed, 5 Apr 2017 10:00:58 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 975CF160B9E; Wed, 5 Apr 2017 08:00:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E5E5B160B91 for ; Wed, 5 Apr 2017 10:00:57 +0200 (CEST) Received: (qmail 11466 invoked by uid 500); 5 Apr 2017 08:00:57 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 11457 invoked by uid 99); 5 Apr 2017 08:00:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Apr 2017 08:00:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B47C21AF91F for ; Wed, 5 Apr 2017 08:00:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id A0xxn2RXI_Xa for ; Wed, 5 Apr 2017 08:00:56 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 363125FDB4 for ; Wed, 5 Apr 2017 08:00:55 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 50ED5E0D45 for ; Wed, 5 Apr 2017 08:00:54 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id B46A92402D for ; Wed, 5 Apr 2017 08:00:53 +0000 (UTC) Date: Wed, 5 Apr 2017 08:00:53 +0000 (UTC) From: "Stas Levin (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-1777) If PipelineEnforcement throws an exception after Pipeline.run() fails, it overwrites the original failure MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 05 Apr 2017 08:00:58 -0000 [ https://issues.apache.org/jira/browse/BEAM-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956479#comment-15956479 ] Stas Levin commented on BEAM-1777: ---------------------------------- [~tgroh] Since I was unable to come up with a proper test for this, would you mind confirming it resolves the use-case you encountered? > If PipelineEnforcement throws an exception after Pipeline.run() fails, it overwrites the original failure > --------------------------------------------------------------------------------------------------------- > > Key: BEAM-1777 > URL: https://issues.apache.org/jira/browse/BEAM-1777 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Reporter: Thomas Groh > Assignee: Stas Levin > > The exception is thrown out of the finally block after the original exception was already thrown, and is not properly suppressed. > If the Pipeline throws an exception in construction (including validation failures), this can cause {{AbandonedNodeEnforcement}} to attempt to traverse a {{Pipeline}} which is invalid, which throws another exception. That exception is improperly propagated instead of the original failure, which complicates debugging. > An example is using an unkeyed input PCollection to a Stateful ParDo. The validation will fail, but the error message will suggest that a node has incompletely specified outputs (which is a consequence rather than a cause of having an invalid transform). -- This message was sent by Atlassian JIRA (v6.3.15#6346)