Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 39F15200C3C for ; Mon, 3 Apr 2017 18:46:46 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 38908160B8D; Mon, 3 Apr 2017 16:46:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5EAB5160B9F for ; Mon, 3 Apr 2017 18:46:45 +0200 (CEST) Received: (qmail 70059 invoked by uid 500); 3 Apr 2017 16:46:44 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 69922 invoked by uid 99); 3 Apr 2017 16:46:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Apr 2017 16:46:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1F6AAC02C5 for ; Mon, 3 Apr 2017 16:46:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id kg5yLZy-dfK1 for ; Mon, 3 Apr 2017 16:46:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id CF2ED5FD6D for ; Mon, 3 Apr 2017 16:46:42 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2845EE053A for ; Mon, 3 Apr 2017 16:46:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id DAF7D24017 for ; Mon, 3 Apr 2017 16:46:41 +0000 (UTC) Date: Mon, 3 Apr 2017 16:46:41 +0000 (UTC) From: "Ted Yu (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (BEAM-1773) Consider allowing Source#validate() to throw exception MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 03 Apr 2017 16:46:46 -0000 [ https://issues.apache.org/jira/browse/BEAM-1773?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated BEAM-1773: ------------------------- Attachment: beam-1773.v1.patch > Consider allowing Source#validate() to throw exception > ------------------------------------------------------ > > Key: BEAM-1773 > URL: https://issues.apache.org/jira/browse/BEAM-1773 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core > Reporter: Ted Yu > Assignee: Jean-Baptiste Onofr=C3=A9 > Attachments: beam-1773.v1.patch > > > In HDFSFileSource.java : > {code} > @Override > public void validate() { > ... > } catch (IOException | InterruptedException e) { > throw new RuntimeException(e); > } > {code} > Source#validate() should be allowed to throw exception so that we don't r= esort to using RuntimeException. > Here was related thread on mailing list: > http://search-hadoop.com/m/Beam/gfKHFOwE0uETxae?subj=3DRe+why+Source+vali= date+is+not+declared+to+throw+any+exception -- This message was sent by Atlassian JIRA (v6.3.15#6346)