Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B91DC200C48 for ; Thu, 6 Apr 2017 19:03:47 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B7C9A160BA6; Thu, 6 Apr 2017 17:03:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 13756160B81 for ; Thu, 6 Apr 2017 19:03:46 +0200 (CEST) Received: (qmail 92543 invoked by uid 500); 6 Apr 2017 17:03:46 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 92506 invoked by uid 99); 6 Apr 2017 17:03:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Apr 2017 17:03:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id B5595CCEBB for ; Thu, 6 Apr 2017 17:03:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id dzcqEdEKEUVq for ; Thu, 6 Apr 2017 17:03:42 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 8EA885F3BF for ; Thu, 6 Apr 2017 17:03:42 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 26BC7E0185 for ; Thu, 6 Apr 2017 17:03:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D759B24016 for ; Thu, 6 Apr 2017 17:03:41 +0000 (UTC) Date: Thu, 6 Apr 2017 17:03:41 +0000 (UTC) From: "Ahmet Altay (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (BEAM-1070) Service Account Based Authentication Broken MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 06 Apr 2017 17:03:47 -0000 [ https://issues.apache.org/jira/browse/BEAM-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmet Altay updated BEAM-1070: ------------------------------ Priority: Minor (was: Critical) > Service Account Based Authentication Broken > ------------------------------------------- > > Key: BEAM-1070 > URL: https://issues.apache.org/jira/browse/BEAM-1070 > Project: Beam > Issue Type: Bug > Components: sdk-py > Environment: CentOS Linux release 7.1.1503 (Core) > Python 2.7.5 > Reporter: Stephen Reichling > Assignee: Ahmet Altay > Priority: Minor > > {{sdks/python/apache_beam/internal/auth.py}} calls into the {{oauth2client.service_account.ServiceAccountCredentials.from_p12_keyfile}} method with invalid and incorrectly-ordered parameters. Compare the [function signature of ServiceAccountCredentials.from_p12_keyfile|https://github.com/google/oauth2client/blob/ae73312942d3cf0e98f097dfbb40f136c2a7c463/oauth2client/service_account.py#L300-L303] with [how it is invoked|https://github.com/apache/incubator-beam/blob/9ded359daefc6040d61a1f33c77563474fcb09b6/sdks/python/apache_beam/internal/auth.py#L150-L154]. This causes a runtime error when one attempts to use a service account to authenticate with the Google Dataflow APIs. > The specific problems are: > - the {{client_scopes}} variable (a list) is passed as a positional parameter where the function signature expects the {{private_key_password}} parameter (a string). > - a keyed parameter, {{user_agent}}, is passed but no such parameter is defined in the function signature. > - no value is provided for {{private_key_password}}. All p12 key files for service accounts issued by Google Cloud have the password {{notasecret}} as documented [here|https://support.google.com/cloud/answer/6158849?hl=en#serviceaccounts], so it's currently not possible to use a Google-issued p12 key file with this implementation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)