Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9029B200C66 for ; Sun, 30 Apr 2017 19:59:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8F373160BA4; Sun, 30 Apr 2017 17:59:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D0E4F160B8C for ; Sun, 30 Apr 2017 19:59:09 +0200 (CEST) Received: (qmail 28209 invoked by uid 500); 30 Apr 2017 17:59:09 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 28200 invoked by uid 99); 30 Apr 2017 17:59:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 30 Apr 2017 17:59:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 8CC3918055C for ; Sun, 30 Apr 2017 17:59:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id LP262_wc0NLv for ; Sun, 30 Apr 2017 17:59:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 124435FE06 for ; Sun, 30 Apr 2017 17:59:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 288C6E0045 for ; Sun, 30 Apr 2017 17:59:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7D85D21DE0 for ; Sun, 30 Apr 2017 17:59:04 +0000 (UTC) Date: Sun, 30 Apr 2017 17:59:04 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-59) Switch from IOChannelFactory to FileSystems MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 30 Apr 2017 17:59:10 -0000 [ https://issues.apache.org/jira/browse/BEAM-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990321#comment-15990321 ] ASF GitHub Bot commented on BEAM-59: ------------------------------------ GitHub user dhalperi opened a pull request: https://github.com/apache/beam/pull/2792 [BEAM-59] Minor style cleanups to WriteOneWindowPerFile Makes the changes in #2779 more standalone You can merge this pull request into a Git repository by running: $ git pull https://github.com/dhalperi/beam writeonefileperwindow-minor Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/2792.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2792 ---- commit 4cd313aa54278b15c2bf2f4d478a028d6b1f6c65 Author: Dan Halperin Date: 2017-04-30T17:57:56Z [BEAM-59] Minor style cleanups to WriteOneWindowPerFile Makes the changes in #2779 more standalone ---- > Switch from IOChannelFactory to FileSystems > ------------------------------------------- > > Key: BEAM-59 > URL: https://issues.apache.org/jira/browse/BEAM-59 > Project: Beam > Issue Type: New Feature > Components: sdk-java-core, sdk-java-gcp > Reporter: Daniel Halperin > Assignee: Daniel Halperin > Fix For: First stable release > > > Right now, FileBasedSource and FileBasedSink communication is mediated by IOChannelFactory. There are a number of issues: > * Global configuration -- e.g., all 'gs://' URIs use the same credentials. This should be per-source/per-sink/etc. > * Supported APIs -- currently IOChannelFactory is in the "non-public API" util package and subject to change. We need users to be able to add new backends ('s3://', 'hdfs://', etc.) directly, without fear that they will be broken. > * Per-backend features: e.g., creating buckets in GCS/s3, setting expiration time, etc. > Updates: > Design docs posted on dev@ list: > Part 1: IOChannelFactory Redesign: > https://docs.google.com/document/d/11TdPyZ9_zmjokhNWM3Id-XJsVG3qel2lhdKTknmZ_7M/edit# > Part 2: Configurable BeamFileSystem: > https://docs.google.com/document/d/1-7vo9nLRsEEzDGnb562PuL4q9mUiq_ZVpCAiyyJw8p8/edit#heading=h.p3gc3colc2cs -- This message was sent by Atlassian JIRA (v6.3.15#6346)