Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4ADCB200C8A for ; Sun, 30 Apr 2017 06:55:48 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 49BF9160BA9; Sun, 30 Apr 2017 04:55:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8E8D7160BB7 for ; Sun, 30 Apr 2017 06:55:47 +0200 (CEST) Received: (qmail 93510 invoked by uid 500); 30 Apr 2017 04:55:46 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 93386 invoked by uid 99); 30 Apr 2017 04:55:46 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 30 Apr 2017 04:55:46 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 7D1C1E0061; Sun, 30 Apr 2017 04:55:46 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: lcwik@apache.org To: commits@beam.apache.org Date: Sun, 30 Apr 2017 04:55:46 -0000 Message-Id: <9e715b7d0b294c18aac66736330e6d92@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [1/2] beam git commit: Remove redundant private on enum constructors archived-at: Sun, 30 Apr 2017 04:55:48 -0000 Repository: beam Updated Branches: refs/heads/master e52228166 -> 33358eb23 Remove redundant private on enum constructors https://docs.oracle.com/javase/specs/jls/se8/html/jls-8.html#jls-8.9.2 Project: http://git-wip-us.apache.org/repos/asf/beam/repo Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/f5304b1b Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/f5304b1b Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/f5304b1b Branch: refs/heads/master Commit: f5304b1b1599b5d373fc0db01f51711a524ec45b Parents: e522281 Author: wtanaka.com Authored: Sat Apr 29 18:27:43 2017 -1000 Committer: Lukasz Cwik Committed: Sat Apr 29 21:55:05 2017 -0700 ---------------------------------------------------------------------- .../core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java | 2 +- .../java/org/apache/beam/sdk/transforms/windowing/PaneInfo.java | 2 +- .../src/main/java/org/apache/beam/sdk/util/CloudKnownType.java | 2 +- .../org/apache/beam/sdk/options/ProxyInvocationHandlerTest.java | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/beam/blob/f5304b1b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java index 3354c67..253a08b 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java @@ -195,7 +195,7 @@ public abstract class FileBasedSink implements Serializable, HasDisplayData { private String filenameSuffix; private String mimeType; - private CompressionType(String suffix, String mimeType) { + CompressionType(String suffix, String mimeType) { this.filenameSuffix = suffix; this.mimeType = mimeType; } http://git-wip-us.apache.org/repos/asf/beam/blob/f5304b1b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/PaneInfo.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/PaneInfo.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/PaneInfo.java index 158bb04..b43c7a3 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/PaneInfo.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/PaneInfo.java @@ -317,7 +317,7 @@ public final class PaneInfo { public final byte tag; - private Encoding() { + Encoding() { assert ordinal() < 16; tag = (byte) (ordinal() << 4); } http://git-wip-us.apache.org/repos/asf/beam/blob/f5304b1b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/CloudKnownType.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/CloudKnownType.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/CloudKnownType.java index b22b3c0..430319b 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/CloudKnownType.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/CloudKnownType.java @@ -84,7 +84,7 @@ enum CloudKnownType { private final String uri; private final Class[] classes; - private CloudKnownType(String uri, Class... classes) { + CloudKnownType(String uri, Class... classes) { this.uri = uri; this.classes = classes; } http://git-wip-us.apache.org/repos/asf/beam/blob/f5304b1b/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ProxyInvocationHandlerTest.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ProxyInvocationHandlerTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ProxyInvocationHandlerTest.java index 4e257f1..323c24c 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ProxyInvocationHandlerTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/options/ProxyInvocationHandlerTest.java @@ -154,7 +154,7 @@ public class ProxyInvocationHandlerTest { MyEnum("MyTestEnum"); private final String value; - private EnumType(String value) { + EnumType(String value) { this.value = value; }