beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dhalperi <...@git.apache.org>
Subject [GitHub] beam pull request #2793: [BEAM-59] Switch mimeType from mutable protected fi...
Date Sun, 30 Apr 2017 18:48:59 GMT
GitHub user dhalperi opened a pull request:

    https://github.com/apache/beam/pull/2793

    [BEAM-59] Switch mimeType from mutable protected field to constructor

    Protected mutable fields are a terrible design pattern, and this
    information is known at construction time.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/beam mimetype

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2793.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2793
    
----
commit 7d8585a1a730443a4f787b6ec14f29749d8d69c8
Author: Dan Halperin <dhalperi@google.com>
Date:   2017-04-30T18:48:12Z

    [BEAM-59] Switch mimeType from mutable protected field to constructor
    
    Protected mutable fields are a terrible design pattern

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message