beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lukecwik <...@git.apache.org>
Subject [GitHub] beam pull request #2772: [BEAM-2005] Swap to use Lists within MatchResult in...
Date Fri, 28 Apr 2017 23:46:59 GMT
GitHub user lukecwik opened a pull request:

    https://github.com/apache/beam/pull/2772

    [BEAM-2005] Swap to use Lists within MatchResult instead of arrays.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    Everywhere in our codebase we go through and want to have lists as the return type. This
also AutoValue's them.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukecwik/incubator-beam hdfs2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2772.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2772
    
----
commit f9fe921cb64a19a092590644e1d94a4b202db3c9
Author: Luke Cwik <lcwik@google.com>
Date:   2017-04-28T23:27:53Z

    [BEAM-2005] Swap to use Lists within MatchResult instead of arrays.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message