beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkff <>
Subject [GitHub] beam pull request #2750: [BEAM-1415] PubsubIO style guide fixes, part 1
Date Thu, 27 Apr 2017 22:13:40 GMT
GitHub user jkff opened a pull request:

    [BEAM-1415] PubsubIO style guide fixes, part 1

    This is just renames, syntax, and AutoValue. Part 2 will be more dramatic (getting rid
of Coder in both read and write).
    R: @reuvenlax 

You can merge this pull request into a Git repository by running:

    $ git pull pubsub-style-pt1

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2750
commit 787207b3e63b65c0fbaac147c15b0577161ee579
Author: Eugene Kirpichov <>
Date:   2017-04-21T00:14:08Z

    Converts PubsubIO.Read to AutoValue

commit 5ec068cb3e36a4629e44cb647183ce2926d174fe
Author: Eugene Kirpichov <>
Date:   2017-04-21T00:19:37Z

    Renames PubsubIO.Read builder methods to be style guide compliant

commit fade0c2f753b2ac19ba9890c9a595e93e77239ca
Author: Eugene Kirpichov <>
Date:   2017-04-21T00:34:11Z

    Converts PubsubIO.Write to AutoValue

commit d4b17ac08be7c1467cead9766773bc5375add7f4
Author: Eugene Kirpichov <>
Date:   2017-04-21T00:37:01Z

    PubsubIO.Read javadoc fixes

commit f04d284257c732c8c3acf9bbb78fcf5089e654fc
Author: Eugene Kirpichov <>
Date:   2017-04-21T00:39:10Z

    PubsubIO.Write javadoc fixes

commit 3bcabd2d7dc3c330c977d4519f31b903f79cbd5b
Author: Eugene Kirpichov <>
Date:   2017-04-21T00:41:48Z

    Renames PubsubIO.Write builder methods to be style guide compliant

commit 00e7ab8ee8e396d77f60833d3bf9b7a3f72c0ef7
Author: Eugene Kirpichov <>
Date:   2017-04-21T00:50:43Z

    Adds PubsubIO.readStrings()

commit f4dca71dd17add4cd05e10d8d1df71d91523e30e
Author: Eugene Kirpichov <>
Date:   2017-04-21T00:52:24Z

    Adds PubsubIO.readProtos()

commit 37f7c556bbb8b91fa0cc90af69697af433745f01
Author: Eugene Kirpichov <>
Date:   2017-04-21T00:54:03Z

    Adds PubsubIO.writeStrings() and writeProtos()

commit dca2a9203cd4d3f9bcee072796c0a90bd39b5e8b
Author: Eugene Kirpichov <>
Date:   2017-04-21T01:32:23Z

    Rename read to parseFn

commit 9f953e4f5bbba89bb08adecd41bfe52c9c3913b5
Author: Eugene Kirpichov <>
Date:   2017-04-21T01:32:38Z

    Rename write to formatFn


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message