beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lukecwik <...@git.apache.org>
Subject [GitHub] beam pull request #2747: [BEAM-1871] Hide internal implementation details of...
Date Thu, 27 Apr 2017 21:03:24 GMT
GitHub user lukecwik opened a pull request:

    https://github.com/apache/beam/pull/2747

    [BEAM-1871] Hide internal implementation details of how we create a DefaultBucket for
GCP Temp Location

    Moved relevant contents of GcpProjectUtil and DefaultProject into GcpOptions.GcpTempLocation
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukecwik/incubator-beam thin_sdk_core3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2747.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2747
    
----
commit 270dfc2a9a05d70155f7f04c93fde6fd2089a537
Author: Luke Cwik <lcwik@google.com>
Date:   2017-04-27T20:50:00Z

    [BEAM-1871] Hide internal implementation details of how we create a DefaultBucket for
GCP Temp Location
    
    Moved relevant contents of GcpProjectUtil and DefaultProject into GcpOptions.GcpTempLocation

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message