beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] beam pull request #2726: Revert "Make WindowedValueCoder an Interface"
Date Thu, 27 Apr 2017 03:12:23 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2726

    Revert "Make WindowedValueCoder an Interface"

    This reverts commit 691269565b537370c133598c2c32bd3f87eb8c29.
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    R: @dhalperi 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam revert_windowed_value_interface

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2726.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2726
    
----
commit d8b61969f6adc276741db95567af0cb98f2ff6f9
Author: Thomas Groh <tgroh@google.com>
Date:   2017-04-27T03:12:04Z

    Revert "Make WindowedValueCoder an Interface"
    
    This reverts commit 691269565b537370c133598c2c32bd3f87eb8c29.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message