beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] beam pull request #2725: Revert "Replace OutputTimeFn UDF with TimestampComb...
Date Thu, 27 Apr 2017 02:35:02 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/2725

    Revert "Replace OutputTimeFn UDF with TimestampCombiner enum"

    This reverts commit f38e4271334fced94e8dc1dc97f47b60fa810586.
    
    It will require a synchronous Dataflow worker container bump.
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    This requires a new Dataflow worker container. A number of things appear to be possibly
broken, so we can merge this in any time in order to see what the other things are.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam revert

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2725.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2725
    
----
commit 83d41fcce0c7b123459e5d26ab9938de49f48dab
Author: Kenneth Knowles <klk@google.com>
Date:   2017-04-27T02:33:55Z

    Revert "Replace OutputTimeFn UDF with TimestampCombiner enum"
    
    This reverts commit f38e4271334fced94e8dc1dc97f47b60fa810586.
    
    It will require a synchronous Dataflow worker container bump.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message