beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vikkyrk <...@git.apache.org>
Subject [GitHub] beam pull request #2688: [BEAM-2080]: Add a custom enforcer rule to check fo...
Date Tue, 25 Apr 2017 23:28:29 GMT
GitHub user vikkyrk opened a pull request:

    https://github.com/apache/beam/pull/2688

    [BEAM-2080]: Add a custom enforcer rule to check for banned classes.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    - Add a custom rule to catch banned classes which can be specified using full path like
`org/apache/beam/Foo.class` or using wildcards like `org/apache/maven/**` 
    - Disable enforcer plugin in parent pom to avoid circular dependency issues with the custom
rule
    - Move enforcer executions to `pluginManagement` and explicitly include them in `sdks`,
`examples` and `runners`.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vikkyrk/incubator-beam mvn_enforcer

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2688.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2688
    
----
commit 48034b365ab89b4e4f37c64345269cb534a87212
Author: Vikas Kedigehalli <vikasrk@google.com>
Date:   2017-04-21T22:10:21Z

    Add a custom rule to check for banned classes.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message