beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] beam pull request #2668: [BEAM-2021] Make Most StandardCoders CustomCoders
Date Mon, 24 Apr 2017 22:50:34 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2668

    [BEAM-2021] Make Most StandardCoders CustomCoders

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    Standard Coders have a defined serialization format and are understood
    within the Runner API, Custom Coders are not. Move existing
    "StandardCoders" to extend CustomCoder, and remove custom cloud object
    related serialization logic where possible.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam fewer_standard_coders

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2668.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2668
    
----
commit 77f416ec28233fd4cae676c604334295ae30a082
Author: Thomas Groh <tgroh@google.com>
Date:   2017-04-20T16:39:12Z

    Stop Extending AtomicCoder

commit 6fc50b2bb7e0416bb04b93595248175020185107
Author: Thomas Groh <tgroh@google.com>
Date:   2017-04-22T00:58:51Z

    Make Most StandardCoders CustomCoders
    
    Standard Coders have a defined serialization format and are understood
    within the Runner API, Custom Coders are not. Move existing
    "StandardCoders" to extend CustomCoder, and remove custom cloud object
    related serialization logic where possible.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message