beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] beam pull request #2606: [BEAM-1871] Remove DeterministicStandardCoder
Date Thu, 20 Apr 2017 01:06:29 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2606

    [BEAM-1871] Remove DeterministicStandardCoder

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    This isn't a particularly useful Coder. It has no defined methods other
    than verifyDeterministic, which has an empty implementation.
    Additionally, there are no guarantees that a DeterministicStandardCoder
    is determinsitic.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam so_many_custom_coders

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2606.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2606
    
----
commit a52186cdd308f155eae34ca287b8bbaf9e95afc9
Author: Thomas Groh <tgroh@google.com>
Date:   2017-04-20T00:58:58Z

    Remove DeterministicStandardCoder
    
    This isn't a particularly useful Coder. It has no defined methods other
    than verifyDeterministic, which has an empty implementation.
    Additionally, there are no guarantees that a DeterministicStandardCoder
    is determinsitic.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message