beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From XuMingmin <...@git.apache.org>
Subject [GitHub] beam pull request #2603: [BEAM-2019] Count.globally() requires default value...
Date Wed, 19 Apr 2017 23:15:39 GMT
GitHub user XuMingmin opened a pull request:

    https://github.com/apache/beam/pull/2603

    [BEAM-2019] Count.globally() requires default values for non-GlobalWindows

    fix below error of Count.globally() when not using `GlobalWindows`:
    ```
    Exception in thread "main" java.lang.IllegalStateException: Default values are not supported
in Combine.globally() \
    if the output PCollection is not windowed by GlobalWindows. Instead, use Combine.globally().withoutDefaults()
\
    to output an empty PCollection if the input PCollection is empty, or Combine.globally().asSingletonView()
\
    to get the default output of the CombineFn if the input PCollection is empty.
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/XuMingmin/beam BEAM-2019

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2603.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2603
    
----
commit 9e49ccc67bd7b0e36f8986d896087cc9250dbe13
Author: mingmxu <mingmxu@ebay.com>
Date:   2017-04-19T23:11:03Z

    Use Combine.globally().withoutDefaults() in Count.globally()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message