beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lukecwik <...@git.apache.org>
Subject [GitHub] beam pull request #2561: [BEAM-1871] Create new GCP core module package and ...
Date Tue, 18 Apr 2017 01:09:21 GMT
GitHub user lukecwik opened a pull request:

    https://github.com/apache/beam/pull/2561

    [BEAM-1871] Create new GCP core module package and move several GCP related classes from
beam-sdks-java-core over.

    
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    This removed several google maven deps from sdk-core, still several remain.
    
    Note that PipelineRunnerTest had no tests that weren't being covered by PipelineOptionsFactory
once I removed the GcpOptions/GcsOptions mock usage which was no longer required.
    
    I moved the TextIOTests that were gs:// specific over to the GCP core module.
    
    Other changes were minor.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukecwik/incubator-beam thin_sdk_core

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2561.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2561
    
----
commit 8bbbd52adc9c3c81ba8ebde2aab79e0e57121eb1
Author: Luke Cwik <lcwik@google.com>
Date:   2017-04-18T01:02:02Z

    [BEAM-1871] Create new GCP core module package and move several GCP related classes from
beam-sdks-java-core over.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message