beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From echauchot <...@git.apache.org>
Subject [GitHub] beam pull request #2523: [BEAM-1272] Align the naming of "generateInitialSpl...
Date Thu, 13 Apr 2017 11:24:06 GMT
GitHub user echauchot opened a pull request:

    https://github.com/apache/beam/pull/2523

    [BEAM-1272] Align the naming of "generateInitialSplits" and "splitIntoBundles" to better
reflect their intention

    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    As discussed in the ML, rename `generateInitialSplits` and `splitIntoBundles` methods
to `splitIntoSubSources` as well as @Test methods and description in javadoc.
    ---
    R: @jkff 
    R: @staslev 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/echauchot/beam BEAM-1272-renaming_generateInitialSplits_and_splitIntoBundles

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2523.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2523
    
----
commit da52c7bff0004553d3cb605e843d88f4aa5ac820
Author: Etienne Chauchot <echauchot@gmail.com>
Date:   2017-04-13T08:55:20Z

    [BEAM-1272] Align the naming of "generateInitialSplits" and "splitIntoBundles" to better
reflect their intention

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message