beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkff <...@git.apache.org>
Subject [GitHub] beam pull request #2500: [BEAM-1915] Removes use of OldDoFn from Apex
Date Tue, 11 Apr 2017 21:46:36 GMT
GitHub user jkff opened a pull request:

    https://github.com/apache/beam/pull/2500

    [BEAM-1915] Removes use of OldDoFn from Apex

    This is the last occurrence of OldDoFn in the Beam repository outside of OldDoFn itself.
    
    It's also used in the Dataflow worker, but it can be deleted entirely once we (Dataflow
team) take care of that.
    
    This is effectively inlining the (trivial) code of GroupAlsoByWindowViaWindowSetDoFn into
ApexGroupByKeyOperator.
    
    R: @tweise 
    CC: @kennknowles 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam apex-gbk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2500.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2500
    
----
commit 1830d4e8a2d96969fafd46241cb51fd893073a02
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-04-11T05:51:16Z

    [BEAM-1915] Removes use of OldDoFn from Apex
    
    This is the last occurrence of OldDoFn in the Beam repository
    outside of OldDoFn itself.
    
    It's also used in the Dataflow worker, but it can be
    deleted entirely once we (Dataflow team) take care of that.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message